Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the ydoc js bundle test #10160

Merged
merged 6 commits into from
Jun 4, 2024
Merged

Implement the ydoc js bundle test #10160

merged 6 commits into from
Jun 4, 2024
+242 −21

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Jun 3, 2024

Pull Request Description

close #9929

Changelog:

  • update: customize Ydoc main hostname and port with environment variables
  • add: Ydoc initialization test

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@4e6 4e6 added the CI: No changelog needed Do not require a changelog entry for this PR. label Jun 3, 2024
@4e6 4e6 self-assigned this Jun 3, 2024
JaroslavTulach
JaroslavTulach approved these changes Jun 4, 2024
View reviewed changes
build.sbt
"io.helidon.webserver" % "helidon-webserver-websocket" % helidonVersion,
"junit" % "junit" % junitVersion % Test,
"com.github.sbt" % "junit-interface" % junitIfVersion % Test,
"com.fasterxml.jackson.core" % "jackson-databind" % jacksonVersion % Test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding test only dependency is OK.

lib/java/ydoc-server/src/main/java/org/enso/ydoc/Main.java Outdated Show resolved Hide resolved
lib/java/ydoc-server/src/test/java/org/enso/ydoc/YdocTest.java
}

private static final class WebServerWsListener implements WsListener {
WebServerWsListener() {}
private static final class LanguageServerConnection implements WsListener {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a mock server, mocking language server protocol. The real Ydoc code is connecting to it and we are verifying it connects and exchanges few messages, rigth?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct

@4e6 4e6 added the CI: Ready to merge This PR is eligible for automatic merge label Jun 4, 2024
@mergify mergify bot merged commit 106007c into develop Jun 4, 2024
35 checks passed
@mergify mergify bot deleted the wip/db/9929-implement-the-ydoc-js-bundle-test branch June 4, 2024 17:45
@enso-bot enso-bot bot mentioned this pull request Jun 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

@hubertp hubertp hubertp approved these changes

@Akirathan Akirathan Awaiting requested review from Akirathan Akirathan is a code owner

Assignees

@4e6 4e6

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the Ydoc JS bundle test
3 participants
@4e6 @hubertp @JaroslavTulach